Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution adapter tests #21421

Conversation

eleanorjboyd
Copy link
Member

adds test coverage for testExecutionAdapter.ts and pytestExecutionAdapter.ts.

@eleanorjboyd eleanorjboyd added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jun 13, 2023
@eleanorjboyd eleanorjboyd self-assigned this Jun 13, 2023
@eleanorjboyd eleanorjboyd changed the base branch from main to resultResolver-feature-branch June 13, 2023 18:27
@eleanorjboyd eleanorjboyd force-pushed the executionAdapter-tests branch from 16ffc56 to a7f5ae2 Compare June 13, 2023 18:44
@eleanorjboyd eleanorjboyd marked this pull request as ready for review June 13, 2023 18:48
@roblourens
Copy link
Member

You don't need reviews for PRs that aren't going into main

@eleanorjboyd
Copy link
Member Author

The plan that I had determined with Brett/Karthik was that I would have each PR go through review to be merged into the feature branch so then the final merge from the feature branch to main isn't so time-consuming since all the parts have already been reviewed. (just a way to manage a large PR/ feature area since I'm less experienced)

@roblourens
Copy link
Member

roblourens commented Jun 13, 2023

So you want an in-depth review? That's fine but it's not what we usually do for PRs in #codereview, especially for feature areas that I'm not familiar with. So if that's what you want you should make that clear or assign a reviewer and remove it from the review channel

@eleanorjboyd
Copy link
Member Author

So you want an in-depth review? That's fine but it's not what we usually do for PRs in #codereview, especially for feature areas that I'm not familiar with. So if that's what you want you should make that clear or assign a reviewer and remove it from the review channel

ok sweet that makes sense- thanks for that extra info on the best place to put these things in the future!

@eleanorjboyd eleanorjboyd merged commit 4d1c196 into microsoft:resultResolver-feature-branch Jun 13, 2023
@eleanorjboyd eleanorjboyd deleted the executionAdapter-tests branch June 13, 2023 23:30
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
adds test coverage for `testExecutionAdapter.ts` and
`pytestExecutionAdapter.ts`.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
adds test coverage for `testExecutionAdapter.ts` and
`pytestExecutionAdapter.ts`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants