Skip to content

Clean up smoke test requirement #21729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Clean up smoke test requirement #21729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eb5b88
try removing smoke test requirement
anthonykim1 Aug 1, 2023
a808d96
remove stale references to smoke-test-requirements.txt
anthonykim1 Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/actions/smoke-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ runs:
cache-dependency-path: |
build/test-requirements.txt
requirements.txt
build/smoke-test-requirements.txt

- name: Install dependencies (npm ci)
run: npm ci --prefer-offline
Expand All @@ -43,11 +42,6 @@ runs:
python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --implementation py --no-deps --upgrade --pre debugpy
shell: bash

- name: pip install smoke test requirements
run: |
python -m pip install --upgrade -r build/smoke-test-requirements.txt
shell: bash

# Bits from the VSIX are reused by smokeTest.ts to speed things up.
- name: Download VSIX
uses: actions/download-artifact@v2
Expand Down
6 changes: 0 additions & 6 deletions build/smoke-test-requirements.txt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion scripts/onCreateCommand.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ source /workspaces/vscode-python/.venv/bin/activate
npx gulp installPythonLibs

/workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/smoke-test-requirements.txt
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt

# Below will crash codespace
Expand Down