Skip to content

fix data to string from buffer for output channel #21821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix data to string from buffer for output channel #21821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client/testing/testController/common/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,10 @@ export class PythonTestServer implements ITestServer, Disposable {
// Take all output from the subprocess and add it to the test output channel. This will be the pytest output.
// Displays output to user and ensure the subprocess doesn't run into buffer overflow.
result?.proc?.stdout?.on('data', (data) => {
spawnOptions?.outputChannel?.append(data);
spawnOptions?.outputChannel?.append(data.toString());
});
result?.proc?.stderr?.on('data', (data) => {
spawnOptions?.outputChannel?.append(data);
spawnOptions?.outputChannel?.append(data.toString());
});
result?.proc?.on('exit', () => {
traceLog('Exec server closed.', uuid);
Expand Down
4 changes: 2 additions & 2 deletions src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ export class PytestTestDiscoveryAdapter implements ITestDiscoveryAdapter {
// Take all output from the subprocess and add it to the test output channel. This will be the pytest output.
// Displays output to user and ensure the subprocess doesn't run into buffer overflow.
result?.proc?.stdout?.on('data', (data) => {
spawnOptions.outputChannel?.append(data);
spawnOptions.outputChannel?.append(data.toString());
});
result?.proc?.stderr?.on('data', (data) => {
spawnOptions.outputChannel?.append(data);
spawnOptions.outputChannel?.append(data.toString());
});
result?.proc?.on('exit', () => {
deferredExec.resolve({ stdout: '', stderr: '' });
Expand Down
4 changes: 2 additions & 2 deletions src/client/testing/testController/pytest/pytestExecutionAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ export class PytestTestExecutionAdapter implements ITestExecutionAdapter {
// Take all output from the subprocess and add it to the test output channel. This will be the pytest output.
// Displays output to user and ensure the subprocess doesn't run into buffer overflow.
result?.proc?.stdout?.on('data', (data) => {
this.outputChannel?.append(data);
this.outputChannel?.append(data.toString());
});
result?.proc?.stderr?.on('data', (data) => {
this.outputChannel?.append(data);
this.outputChannel?.append(data.toString());
});

result?.proc?.on('exit', () => {
Expand Down