Updates to python locator #23446
Merged
Updates to python locator #23446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 17, 2024
| None => None, | ||
| }; | ||
| if reported.contains(&exe.to_string_lossy().to_string()) { | ||
| // If this file name is `python3`, then ignore this for now. |
There was a problem hiding this comment.
The exe that will be reported is the short name /opt/homebrew/bin/python3.12
I.e. i'm addressing this comment here #23445 (comment)
DonJayamanne
commented
May 17, 2024
| @@ -117,7 +128,12 @@ fn get_pure_python_environment( | |||
| .into_os_string() | |||
| .into_string() | |||
| .unwrap()]), | |||
| )) | |||
| ); | |||
| if file_name.ends_with("-win32") { | |||
There was a problem hiding this comment.
On windows we have 32bit, and it can be easily identified, hence returning that information.
DonJayamanne
commented
May 17, 2024
| @@ -96,16 +96,7 @@ pub fn get_version(python_executable: &PathBuf) -> Option<String> { | |||
| return Some(pyenv_cfg.version); | |||
| } | |||
| } | |||
|
|
|||
| let output = Command::new(python_executable) | |||
There was a problem hiding this comment.
Discussed that we would not spawn
DonJayamanne
added
no-changelog
DonJayamanne
commented
May 20, 2024
| @@ -66,6 +68,17 @@ pub fn is_virtualenvwrapper(env: &PythonEnv, environment: &dyn Environment) -> b | |||
| false | |||
| } | |||
|
|
|||
| fn get_project(env: &PythonEnv) -> Option<PathBuf> { | |||
There was a problem hiding this comment.
virtualenvwrappers can also have a project path
DonJayamanne
commented
May 20, 2024
| @@ -214,7 +261,8 @@ impl Locator for PyEnv<'_> { | |||
|
|
|||
| fn find(&mut self) -> Option<LocatorResult> { | |||
| let pyenv_binary = get_pyenv_binary(self.environment)?; | |||
| let manager = messaging::EnvManager::new(pyenv_binary, None, EnvManagerType::Pyenv); | |||
| let version = get_pyenv_manager_version(&pyenv_binary, self.environment); | |||
There was a problem hiding this comment.
Updates to extract version of pyenv
karthiknadig
approved these changes
May 20, 2024
DonJayamanne
added a commit
that referenced
this pull request
Jun 24, 2024
The search algorithm has been documented here https://github.com/microsoft/vscode-python/wiki/Python-Environment-Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search algorithm has been documented here https://github.com/microsoft/vscode-python/wiki/Python-Environment-Search