Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix django manage.py path validation #24019

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

eleanorjboyd
Copy link
Member

fixes #24001

@eleanorjboyd eleanorjboyd self-assigned this Aug 28, 2024
@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Aug 28, 2024
@eleanorjboyd
Copy link
Member Author

A note- needed to skip tests as catching the error how it is thrown now is difficult with the threading on named pipes which is our current design to run tests on the pure python side. I will revisit and make a correct test after upcoming changes to communication (and moving to file communication)

@eleanorjboyd eleanorjboyd marked this pull request as ready for review August 28, 2024 21:36
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 28, 2024
@Tyriar Tyriar modified the milestones: August 2024, September 2024 Sep 3, 2024
@eleanorjboyd eleanorjboyd merged commit 884efad into microsoft:main Sep 3, 2024
44 checks passed
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Sep 3, 2024
eleanorjboyd added a commit that referenced this pull request Sep 4, 2024
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django testing - infinite progress in case of a discovery failure
3 participants