Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of mocked output channel in virtual workspace #24051

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove use of mocked output channel in virtual workspace #24051

merged 1 commit into from
Sep 4, 2024

Conversation

karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Sep 4, 2024
@karthiknadig karthiknadig self-assigned this Sep 4, 2024
@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Sep 4, 2024
@karthiknadig karthiknadig mentioned this pull request Sep 4, 2024
Closed
@heejaechang
Copy link

@karthiknadig we need this to be in both python ext stable and prerelease before pylance does stable release for this month

@karthiknadig karthiknadig marked this pull request as ready for review September 4, 2024 18:48
@karthiknadig karthiknadig merged commit e694910 into microsoft:main Sep 4, 2024
42 of 44 checks passed
@karthiknadig karthiknadig deleted the mock1 branch September 4, 2024 18:48
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 4, 2024
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Sep 4, 2024
@karthiknadig @eleanorjboyd
Remove use of mocked output channel in virtual workspace (microsoft#2…
946ad9f 
…4051)
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Sep 4, 2024
@karthiknadig @eleanorjboyd
Remove use of mocked output channel in virtual workspace (microsoft#2…
64d6ca8 
…4051)
@eleanorjboyd eleanorjboyd mentioned this pull request Sep 4, 2024
Closed
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Sep 4, 2024
@karthiknadig @eleanorjboyd
Remove use of mocked output channel in virtual workspace (microsoft#2…
ed93e9e 
…4051)
karthiknadig added a commit that referenced this pull request Sep 4, 2024
@eleanorjboyd @karthiknadig
Remove use of mocked output channel in virtual workspace (#24051) (#2…
d73a2df 
…4056)

cherry pick

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
@karthiknadig @anthonykim1
Remove use of mocked output channel in virtual workspace (microsoft#2…
b2b53d3 
…4051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@heejaechang heejaechang heejaechang approved these changes

Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@karthiknadig @heejaechang @rchiodo