Fix mismatched traceback in pythonrc.py injection
#25480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since vscode-python injects
PYTHONSTARTUPintopythonrc.pyto show the "Ctrl click to launch VS Code Native REPL" message, traceback always shows lines insidepythonrc.pyin the interactive console.Example:
That's because python sets
__main__to thepythonrc.pymodule, which has a__loader__attribute. The__loader__object is then exposed in the global namespace of the interactive console. However, linecache uses__loader__to get the source code, causing the mismatch.After this PR, the traceback points to the right source now:
In the
_pyrepl.__main__module, there was some comment mentioning this behavior and they set__loader__ = Noneto avoid this. See python/cpython#129098 for more information