Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a message with options when default Mac interpreter is selected #2570

Merged
merged 3 commits into from
Sep 14, 2018

Conversation

DonJayamanne
Copy link

Fixes #1689

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has unit tests & system/integration tests
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne requested a review from d3r3kk September 13, 2018 20:00
@DonJayamanne
Copy link
Author

@d3r3kk
I'd like to change the commands to actual objects than have separate command handlers. I.e. command object will have a handle method.
Didn't make that change now, as it would add noise to the PR.
Once you've review the PR and feel its warranted, then we can proceed on that (either in this same PR or later).

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I really do like how you've devised the diagnostics routines for the extension. File naming is one of the things I've not yet fully come to terms yet with in this codebase - most of the codebases I've worked on previously have a 1:1 relationship between class defined within.

@@ -0,0 +1,116 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question here: Why don't we name the files with the name of the class defined within it? Makes it a bit more discoverable to find things using Ctrl+p instead of Ctrl+Shift+f then searching...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a blocker, just asking why)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, just that in JS/TS I haven't come across this rule.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally fair, and what I expected. I am 100% certain that the rules in my prior codebases were enforced socially, perhaps canonically-ish in C#/C++.

src/client/extension.ts Show resolved Hide resolved
@d3r3kk
Copy link

d3r3kk commented Sep 13, 2018

I'd like to change the commands to actual objects than have separate command handlers. I.e. command object will have a handle method.

Yes, please do open a different PR for the change you describe here. Would like to chat about it with you first to get an understanding of what you mean. (I think I follow, but want to be sure).

@DonJayamanne DonJayamanne merged commit d0625be into microsoft:master Sep 14, 2018
@DonJayamanne DonJayamanne deleted the issue1689MacInterpreter branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Extension Suggestion for macOS system Python is not actionable
2 participants