Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress indicator when loading interpreters and speed up detection of new virtual envs in workspace #3079

Merged
merged 20 commits into from
Nov 1, 2018
Merged

Progress indicator when loading interpreters and speed up detection of new virtual envs in workspace #3079

merged 20 commits into from
Nov 1, 2018

Conversation

DonJayamanne
Copy link

For #656

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk
d3r3kk suggested changes Nov 1, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think separating the AzureCDN and interpreter fs watcher changes into separate PRs should be considered.

src/client/activation/languageServer/languageServerPackageRepository.ts Outdated Show resolved Hide resolved
@DonJayamanne
Copy link
Author

DonJayamanne commented Nov 1, 2018 •
edited
Loading

New changes:

  • When extension is refreshing the list of interpreters, we'll display a progress message Refreshing Python Interpreters
  • Add a progress label for this.
  • Master has been merged hence no more Azure CDN stuff in here.

@d3r3kk Please re-review (until I get the tests fixed)

@DonJayamanne DonJayamanne reopened this Nov 1, 2018
@DonJayamanne DonJayamanne changed the title Speed up detection of new virtual environments in workspace Add progress indicator when loading interpreters and speed up detection of new virtual environments Nov 1, 2018
@DonJayamanne DonJayamanne changed the title Add progress indicator when loading interpreters and speed up detection of new virtual environments Progress indicator when loading interpreters and speed up detection of new virtual envs in workspace Nov 1, 2018
@DonJayamanne DonJayamanne merged commit 35ab321 into microsoft:master Nov 1, 2018
@DonJayamanne DonJayamanne deleted the issue656Interpreter branch November 7, 2018 00:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@d3r3kk d3r3kk Awaiting requested review from d3r3kk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @brettcannon @d3r3kk