Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to pylint checks #3225

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fixes to pylint checks #3225

merged 2 commits into from
Nov 7, 2018

Conversation

DonJayamanne
Copy link

For #974

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

brettcannon
brettcannon approved these changes Nov 6, 2018
View reviewed changes
src/client/linters/linterManager.ts Outdated Show resolved Hide resolved
@brettcannon @DonJayamanne
oh well ok
e248a30 
Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>
@DonJayamanne DonJayamanne merged commit e3b047d into microsoft:master Nov 7, 2018
@DonJayamanne DonJayamanne deleted the issue974DefaultLinter branch November 7, 2018 00:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @brettcannon