Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DISCUSS - Start LS in background #3559

Closed
wants to merge 1 commit into from

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Dec 5, 2018

For #3020

  • Just stopping the await in extension might be enough

  • We may need some further hook up to defer LS activities cleanly

  • Note that there are some extra items that shouldn't merge to master

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)

  • Title summarizes what is changing

  • Has a news entry file (remember to thank yourself!)

  • Unit tests & system/integration tests are added/updated

  • Test plan is updated as appropriate

  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

For microsoft#3020

- Just stopping the await in extension might be enough
- We may need some further hook up to defer LS activities cleanly
- Note that there are some extra items that shouldn't merge to master
@d3r3kk d3r3kk requested a review from DonJayamanne December 5, 2018 05:52
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unfortunately this won't be enough, we need to propagate this promise all the way up to the extension.
  • We need to pass this promise to the isReady of the extension API exposed by us. Just because extension activates doesn't mean the language server has started successfully, hence LS server tests WILL fail if LS is still busy loading.
  • Also, delaying this will definitely mess and potentially break Intelli Code. So we need to consider that as well.
  • Also, if the activation takes some time, then unit test code lenses and other parts of the code will need to wait fort this to complete, i.e. ensure code that uses language server can still function correctly while LS is still starting in the background.
  • Finally, please log the errors use traceError.

@d3r3kk
Copy link
Author

d3r3kk commented Dec 9, 2018

Closing to do some further work...

@d3r3kk d3r3kk closed this Dec 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants