Fix interrupt to support a timeout and handle crashes #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem with cancel in jupyterExecution with cached promise
rchiodo
commented
Dec 10, 2018
DonJayamanne
requested changes
Dec 10, 2018
| .catch(err => { | ||
| status.dispose(); |
There was a problem hiding this comment.
Don't we need to notify the user? #Resolved
There was a problem hiding this comment.
| if (this.specFile && | ||
| IsGuidRegEx.test(path.basename(path.dirname(this.specFile)))) { | ||
| try { | ||
| fs.removeSync(path.dirname(this.specFile)); |
There was a problem hiding this comment.
Please make this async. #Resolved
There was a problem hiding this comment.
There was a problem hiding this comment.
Although I could just ignore errors on it.
In reply to: 240369636 [](ancestors = 240369636,240364388)
There was a problem hiding this comment.
It can't be. The dispose can't return anything.
A number of async dispose methods already exist in DS code, how is this any different?
There was a problem hiding this comment.
We must always avoid sync operations. Specially here, perfoming I/O operations in dispose slows down overall dispose method time.
DonJayamanne
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3511
Also did some work around making sure cancel behaves correctly. Cancelling a connection happens on exporting a file and running all cells. There was a bug where the cancel token from one request was being reused in another.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)