Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests related to the onEnter format provider #3726

Merged
merged 5 commits into from
Dec 17, 2018
Merged

Fix tests related to the onEnter format provider #3726

merged 5 commits into from
Dec 17, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Dec 17, 2018 •
edited
Loading

For #3674

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne changed the title WIP - Fix tests Fix tests related to the onEnter format provider Dec 17, 2018
d3r3kk
d3r3kk approved these changes Dec 17, 2018
View reviewed changes
@DonJayamanne DonJayamanne merged commit 77595a1 into microsoft:master Dec 17, 2018
@DonJayamanne DonJayamanne deleted the issue3674 branch May 24, 2019 20:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @d3r3kk