Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running an entire file whether or not it has cells #3938

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 9, 2019

For #3362 - Make the run all cells command work whether or not we have cells.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Jan 9, 2019
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #3938 into master will decrease coverage by 24%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3938     +/-   ##
========================================
- Coverage      78%     54%    -23%     
========================================
  Files         402     323     -79     
  Lines       18568   13488   -5080     
  Branches     2983    2096    -887     
========================================
- Hits        14350    7220   -7130     
- Misses       4216    5789   +1573     
- Partials        2     479    +477
Flag Coverage Δ
#Linux ?
#Windows ?
#macOS ?
Impacted Files Coverage Δ
...ient/datascience/editor-integration/codewatcher.ts 63% <0%> (-12%) ⬇️
...nittests/common/testVisitors/resultResetVisitor.ts 11% <0%> (-89%) ⬇️
...nt/unittests/pytest/services/testMessageService.ts 9% <0%> (-88%) ⬇️
...nt/unittests/common/services/testResultsService.ts 5% <0%> (-88%) ⬇️
...t/common/variables/environmentVariablesProvider.ts 13% <0%> (-87%) ⬇️
...ter/configuration/services/globalUpdaterService.ts 15% <0%> (-85%) ⬇️
src/client/common/process/proc.ts 13% <0%> (-82%) ⬇️
src/client/linters/pylint.ts 19% <0%> (-80%) ⬇️
src/client/unittests/pytest/runner.ts 18% <0%> (-80%) ⬇️
.../configuration/services/workspaceUpdaterService.ts 20% <0%> (-80%) ⬇️
... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2655f...8772271. Read the comment docs.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 8e5c80b into master Jan 9, 2019
@rchiodo rchiodo deleted the rchiodo/add_run_entire_file branch January 10, 2019 17:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants