-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added action buttons to top of Test Explorer #4327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4327 +/- ##
========================================
+ Coverage 56% 78% +22%
========================================
Files 361 436 +75
Lines 15272 20244 +4972
Branches 2373 3246 +873
========================================
+ Hits 8494 15612 +7118
+ Misses 6234 4629 -1605
+ Partials 544 3 -541
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use svg files instead of png
files.
Use files from VSC itself, here are the icons:
-
Play/start (dark & light) = https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/debug/browser/media/start.svg
-
Debug Dark - https://github.com/Microsoft/vscode/blob/master/extensions/npm/resources/dark/debug.svg
-
Debug light - https://github.com/Microsoft/vscode/blob/master/extensions/npm/resources/light/debug.svg
-
Discover (use refresh icon) - https://github.com/Microsoft/vscode/blob/master/extensions/npm/resources/light/refresh.svg
& https://github.com/Microsoft/vscode/blob/master/extensions/npm/resources/dark/refresh.svg -
Play Failed (we need to generate a red icon based off the green SVG). Should be straightforward enough.
-
Problems (failed)
@DonJayamanne Can you elaborate? The issue doesn't state this. Should i have a button for that? |
Please ignore that comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the same names and images from vscode:
- use
start.svg
instead ofplay.svg
- use
debug.svg
instead ofdebugger.svg
- use
start-failed.svg
instead ofplayFailed.svg
Please ensure you test the icons in both light and dark themes of VS code.
0f103a9
to
62e5123
Compare
For #4275
Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)