Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for poetry dependency manager #4654

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

DonJayamanne
Copy link

For #1871

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #4654 into master will decrease coverage by 1%.
The diff coverage is 81%.

@@           Coverage Diff           @@
##           master   #4654    +/-   ##
=======================================
- Coverage      77%     77%   -<1%     
=======================================
  Files         445     446     +1     
  Lines       21074   21121    +47     
  Branches     3450    3455     +5     
=======================================
+ Hits        16118   16151    +33     
- Misses       4952    4966    +14     
  Partials        4       4
Flag Coverage Δ
#Linux 65% <45%> (ø) ⬇️
#Windows 66% <45%> (ø) ⬇️
#macOS 65% <45%> (ø) ⬇️

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit 97444ef into microsoft:master Mar 7, 2019
@DonJayamanne DonJayamanne deleted the issue1871 branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants