Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to multi-root support for tests #4667

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 7, 2019

For #4268

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #4667 into master will increase coverage by 1%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master   #4667   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         446     446           
  Lines       21218   21220    +2     
  Branches     3471    3472    +1     
======================================
+ Hits        16290   16294    +4     
+ Misses       4924    4922    -2     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <47%> (+1%) ⬆️
#Windows 66% <47%> (+1%) ⬆️
#macOS 66% <47%> (+1%) ⬆️

@DonJayamanne DonJayamanne marked this pull request as ready for review March 11, 2019 18:54
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I think there's one typo of a variable name.

src/client/unittests/main.ts Show resolved Hide resolved
@DonJayamanne DonJayamanne merged commit 0f89926 into microsoft:master Mar 11, 2019
@DonJayamanne DonJayamanne deleted the issue4268MultiRoot branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants