Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors behind errors in the Python Interactive window. #4683

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 8, 2019

For #3175

Also make sure empty markdown doesn't cause a split.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Mar 8, 2019
@rchiodo
Copy link
Author

rchiodo commented Mar 8, 2019

I had a customer complain on the colorization issue that I fixed that colors still weren't working. That was because of this problem.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #4683 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4683   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         447     447           
  Lines       21343   21345    +2     
  Branches     3491    3493    +2     
======================================
+ Hits        16344   16346    +2     
  Misses       4995    4995           
  Partials        4       4
Flag Coverage Δ
#Linux 66% <67%> (+1%) ⬆️
#Windows 66% <67%> (ø) ⬇️
#macOS 65% <67%> (+1%) ⬆️

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 189119a into master Mar 8, 2019
@rchiodo rchiodo deleted the rchiodo/fix_error_colors branch May 1, 2019 18:22
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants