Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash imports instead of using a known list #4860

Merged
merged 7 commits into from
Mar 21, 2019
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 20, 2019

For #4852

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #4860 into master will decrease coverage by 1%.
The diff coverage is 95%.

@@           Coverage Diff           @@
##           master   #4860    +/-   ##
=======================================
- Coverage      62%     62%   -<1%     
=======================================
  Files         373     373            
  Lines       14689   14660    -29     
  Branches     1161    1161            
=======================================
- Hits         9080    9050    -30     
- Misses       5407    5408     +1     
  Partials      202     202

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 97d5235 into master Mar 21, 2019
@rchiodo rchiodo deleted the rchiodo/hash_imports branch March 21, 2019 00:28
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants