Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure prompt is displayed to install pylint when user has configured pylint #5356

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Ensure prompt is displayed to install pylint when user has configured pylint #5356

merged 2 commits into from
Apr 18, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 18, 2019 •
edited
Loading

For #5087

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

DonJayamanne
DonJayamanne approved these changes Apr 18, 2019
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple and readable.

src/test/linters/linterinfo.unit.test.ts Show resolved Hide resolved
@karrtikr karrtikr merged commit b9a86b0 into microsoft:master Apr 18, 2019
@karrtikr karrtikr deleted the pylintbug branch April 18, 2019 06:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrtikr @DonJayamanne