-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure using request: launch item in launch.json for debugging sends pathmappings #5552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes to package.json that would enable pathMapptings
in launch.json
for launch
types.
I.e. from a users perspective this is still broken.
Also, in light of Remote Extensions I'm not sure we need this, will need to discuss with team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following change for launch
configuration:
- If
debugConfiguration.pathMappings
is empty, then always add the following as a default value:
{
"localRoot": "${workspaceFolder}",
"remoteRoot": "."
}
995d1de
to
e73ac3e
Compare
For #3568
[ ] Appropriate comments and documentation strings in the code[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.