Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure using request: launch item in launch.json for debugging sends pathmappings #5552

Merged
merged 5 commits into from
May 21, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 4, 2019

For #3568

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to package.json that would enable pathMapptings in launch.json for launch types.
I.e. from a users perspective this is still broken.
Also, in light of Remote Extensions I'm not sure we need this, will need to discuss with team.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following change for launch configuration:

  • If debugConfiguration.pathMappings is empty, then always add the following as a default value:
                {
                    "localRoot": "${workspaceFolder}",
                    "remoteRoot": "."
                }

@karrtikr karrtikr force-pushed the pathmappings branch 2 times, most recently from 995d1de to e73ac3e Compare May 20, 2019 23:11
package.json Outdated Show resolved Hide resolved
@DonJayamanne DonJayamanne merged commit 1fad96f into microsoft:master May 21, 2019
@karrtikr karrtikr deleted the pathmappings branch May 21, 2019 21:29
DonJayamanne added a commit that referenced this pull request May 30, 2019
DonJayamanne added a commit that referenced this pull request May 30, 2019
* Revert "Ensure using request: launch item in launch.json for debugging sends pathmappings (#5552)"

This reverts commit 1fad96f.

* Update change log

* Update version numbers
DonJayamanne added a commit that referenced this pull request May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants