Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to shell detection #5923

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Fixes to shell detection #5923

merged 2 commits into from
Jun 5, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 5, 2019 •
edited
Loading

For #5916

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@ericsnowcurrently ericsnowcurrently self-requested a review June 5, 2019 21:19
ericsnowcurrently
ericsnowcurrently approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming you didn't break anything with the refactoring :) )

Also, it would have been much easier to review if the refactoring had been done in a separate PR. :)

@DonJayamanne DonJayamanne merged commit 114ee5e into microsoft:master Jun 5, 2019
@DonJayamanne DonJayamanne deleted the fixesToShellDetection branch June 6, 2019 22:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @ericsnowcurrently