Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation after string literals containing escaped characters #6440

Merged
merged 11 commits into from
Jul 8, 2019
Merged

Fix indentation after string literals containing escaped characters #6440

merged 11 commits into from
Jul 8, 2019

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jul 3, 2019 •
edited
Loading

For #4241

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@kimadeline kimadeline changed the title Fix indentation after string literals containing escaped characters. Fix indentation after string literals containing escaped characters Jul 3, 2019
ericsnowcurrently
ericsnowcurrently reviewed Jul 3, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just hesitant to approve without tests.

src/client/extension.ts Outdated Show resolved Hide resolved
@kimadeline
Copy link
Author

kimadeline commented Jul 4, 2019 •
edited
Loading

Coverage went down because extension.ts is now picked up by coveralls, filed #6457 to make sure to add more unit tests to cover src/client/extension.ts

ericsnowcurrently
ericsnowcurrently approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the tests.

ericsnowcurrently
ericsnowcurrently approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit d69efae into microsoft:master Jul 8, 2019
@kimadeline kimadeline deleted the 4241-indentation-string-escaped-character branch July 8, 2019 21:16
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimadeline @ericsnowcurrently