Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified telemetry with regards to discovery of python environments #6903

Merged
merged 6 commits into from
Aug 13, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Aug 8, 2019

For #5593

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

src/client/telemetry/types.ts Outdated Show resolved Hide resolved
src/client/telemetry/index.ts Outdated Show resolved Hide resolved
@ericsnowcurrently ericsnowcurrently removed their request for review August 13, 2019 16:56
@karrtikr karrtikr merged commit ed6b044 into microsoft:master Aug 13, 2019
@karrtikr karrtikr deleted the telemetry branch August 13, 2019 22:13
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants