Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add regex to dedent else and friends (#6497)" #6945

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Revert "Add regex to dedent else and friends (#6497)" #6945

merged 1 commit into from
Aug 12, 2019

Conversation

kimadeline
Copy link

This reverts commit 2454423.

For #6886

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Aug 12, 2019
ericsnowcurrently
ericsnowcurrently approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit 2402dd5 into microsoft:master Aug 12, 2019
@kimadeline kimadeline deleted the 6886-indentation-issues branch August 12, 2019 21:19
ericsnowcurrently added a commit to ericsnowcurrently/vscode-python that referenced this pull request Aug 12, 2019
@ericsnowcurrently
Revert "Revert "Add regex to dedent else and friends (microsoft#6497)…
705e6ea 
…" (microsoft#6945)"

This reverts commit 2402dd5.
ericsnowcurrently added a commit to ericsnowcurrently/vscode-python that referenced this pull request Aug 12, 2019
@ericsnowcurrently
Revert "Revert "Add regex to dedent else and friends (microsoft#6497)…
b8ae859 
…" (microsoft#6945)"

This reverts commit 2402dd5.
DonJayamanne pushed a commit that referenced this pull request Aug 13, 2019
@kimadeline @DonJayamanne
Revert "Add regex to dedent else and friends (#6497)" (#6945)
3f72df1 
This reverts commit 2454423.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimadeline @ericsnowcurrently