Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove donjamayanne.jupyter integration #7277

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

mikeroll
Copy link

@mikeroll mikeroll commented Sep 7, 2019

Closes #6052

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented Sep 7, 2019

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Sep 7, 2019

Codecov Report

Merging #7277 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7277      +/-   ##
==========================================
+ Coverage   58.33%   58.38%   +0.05%     
==========================================
  Files         493      492       -1     
  Lines       21661    21610      -51     
  Branches     3486     3475      -11     
==========================================
- Hits        12635    12618      -17     
+ Misses       8243     8214      -29     
+ Partials      783      778       -5
Impacted Files Coverage Δ
src/client/common/constants.ts 100% <ø> (ø) ⬆️
src/client/linters/types.ts 100% <ø> (ø) ⬆️
src/client/linters/lintingEngine.ts 21.97% <100%> (+1.38%) ⬆️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94abff9...b695faf. Read the comment docs.

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @mikeroll !

@kimadeline kimadeline merged commit 255113f into microsoft:master Sep 16, 2019
@mikeroll mikeroll deleted the remove-jupyter branch September 17, 2019 18:59
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete client/jupyter provider.ts
4 participants