Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back the runMagicCommands but deprecate it #7382

Merged
merged 4 commits into from
Sep 13, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Sep 12, 2019

For #7294

Support old runMagicCommands and deprecate the setting

Fix #7370 - Errors make the run button go away

Also fix a number of issues found while testing

  • Text output has a weird border on the right after the change for no horizontal scrolling
  • Native editors can flash weirdly

@rchiodo rchiodo self-assigned this Sep 12, 2019
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #7382 into master will increase coverage by 0.65%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7382      +/-   ##
==========================================
+ Coverage    57.8%   58.45%   +0.65%     
==========================================
  Files         493      493              
  Lines       21396    21750     +354     
  Branches     3481     3487       +6     
==========================================
+ Hits        12367    12715     +348     
- Misses       8246     8257      +11     
+ Partials      783      778       -5
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterNotebook.ts 6.01% <0%> (-0.04%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 6.41% <0%> (ø) ⬆️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967f7b1...500cb38. Read the comment docs.

@rchiodo rchiodo merged commit da7a50f into master Sep 13, 2019
@rchiodo rchiodo deleted the rchiodo/fix_runmagiccommands branch September 13, 2019 15:10
@lock lock bot locked as resolved and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on Native editor cell hides the run button totally
3 participants