Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests in nodejs #7456

Merged
merged 44 commits into from
Sep 27, 2019
Merged

Smoke tests in nodejs #7456

merged 44 commits into from
Sep 27, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Sep 18, 2019

For #6511

  • Only runs smoke tests using the UI Tests
  • There are more UI Tests, but not enabled
    • Other UI Tests will be enabled in a separate PR
    • Those other UI tests will be run as part of a separate nightly uitest pipeline (again separate PR)
    • Leaving that code in this PR, no point in removing all of that.

If required I could break the PR into separate PRs as follows:

  • Azure Pipeline changes for UI Tests
  • Extension code changes to exclude UI Tests stuff (.vscodeignore, .gitignore, etc changes)
  • Smoke (UI Test) code changes (only code)
  • Smoke (UI Test) BDD feature files
  • Smoke enabled (tie all stuff together)

Azure Pipelines

  • Smoke (UI) Tests run as a separate stage (in parallel with the standard test stage).
  • Build/compile phase of UI Tests run as a separate stage (in parallel with standard build stage)
  • In Reports stage, I've added a UI_Test_Report job that will merge all UI Test reports into one (just so we can look at a single report).
  • All UI test results are published into Azure Tests reports tab (so we can see results there too - just used an npm package for this).

Screenshot 2019-09-26 at 13 50 05

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #7456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7456   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         493      493           
  Lines       21990    21990           
  Branches     3531     3531           
=======================================
  Hits        12902    12902           
  Misses       8281     8281           
  Partials      807      807

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615ea01...e22b973. Read the comment docs.

@DonJayamanne
Copy link
Author

@rchiodo @karrtikr @IanMatthewHuff

Ready for review, no rush

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit c30eeae into microsoft:master Sep 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
@DonJayamanne DonJayamanne deleted the smoke branch April 30, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants