Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pyenv and direnv #854

Merged
merged 46 commits into from
Feb 22, 2018
Merged

Support pyenv and direnv #854

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
6546892
Fix pylint search
Feb 16, 2018
76af122
Handle quote escapes in strings
Feb 16, 2018
5d4d022
Escapes in strings
Feb 16, 2018
29edac2
CR feedback
Feb 16, 2018
0492aab
Missing pip
Feb 17, 2018
d0a449f
Test
Feb 17, 2018
55197c3
Tests
Feb 17, 2018
f6a0123
Tests
Feb 17, 2018
d07d3ef
Mac python path
Feb 17, 2018
2b0cc92
Tests
Feb 17, 2018
3867ec2
Tests
Feb 17, 2018
85fc4ef
Test
Feb 17, 2018
00887a4
"Go To Python object" doesn't work
Feb 17, 2018
f89dd96
Proper detection and type population in virtual env
Feb 17, 2018
32394e2
Test fixes
Feb 17, 2018
2e9c039
Simplify venv check
Feb 17, 2018
ec563c7
Remove duplicates
Feb 17, 2018
2ad4475
Test
Feb 18, 2018
1ee0be2
Discover pylintrc better + tests
Feb 19, 2018
44665b9
Merge branch 'master' into 804
Feb 19, 2018
29d3925
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Feb 19, 2018
04c5733
Undo change
Feb 19, 2018
37328a5
CR feedback
Feb 20, 2018
55ff4e5
Set interprereter before checking install
Feb 20, 2018
9a0cfa8
Merge master
Feb 20, 2018
023af49
Merge master
Feb 20, 2018
436e5a9
Fix typo and path compare on Windows
Feb 20, 2018
a53d815
Rename method
Feb 20, 2018
7f3e4fa
#815 - 'F' in flake8 means warning
Feb 20, 2018
da034f4
730 - same folder temp
Feb 20, 2018
71a508d
Properly resolve ~
Feb 20, 2018
4422811
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Feb 20, 2018
6d91912
Test
Feb 21, 2018
ff6f6d2
Test
Feb 21, 2018
7446afb
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Feb 21, 2018
a7b2854
Fix dot spacing
Feb 21, 2018
a9457f2
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Feb 21, 2018
c7c07de
Remove banner
Feb 21, 2018
e9eec39
Delete banner code
Feb 21, 2018
7b5d76b
Add pyenv and direnv folders
Feb 21, 2018
d62a8e0
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Feb 21, 2018
66395c5
Basic venv path search tests
Feb 22, 2018
005f65e
PYENV_ROOT resolution
Feb 22, 2018
63e195c
PYENV_ROOT test
Feb 22, 2018
b142a49
Use ICurrentProcess
Feb 22, 2018
005875f
Fix travis
Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/format/extension.format.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ suite('Formatting', () => {
const formattedFile = path.join(targetDir, resultsName);

if (!fs.pathExistsSync(targetDir)) {
fs.mkdirSync(targetDir);
fs.mkdirpSync(targetDir);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I couldn't be bothered to identify the problem, I just created the folder with a dummy .ts file in the formatting directory.
You might want to merge master

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okaaaay :-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My solution was to ensure the directory always exists. I didn't check what code was looking for it.

}
fs.copySync(path.join(sourceDir, originalName), fileToFormat, { overwrite: true });
fs.copySync(path.join(sourceDir, resultsName), formattedFile, { overwrite: true });
Expand Down