Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress indicator when switching kernels #9134

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Add progress indicator when switching kernels #9134

merged 3 commits into from
Dec 16, 2019

Conversation

DonJayamanne
Copy link

For #8866

@DonJayamanne DonJayamanne requested review from IanMatthewHuff and rchiodo and removed request for IanMatthewHuff December 16, 2019 18:21
@codecov-io
Copy link

codecov-io commented Dec 16, 2019 •
edited
Loading

Codecov Report

Merging #9134 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9134      +/-   ##
==========================================
- Coverage   57.07%   57.06%   -0.01%     
==========================================
  Files         551      551              
  Lines       29203    29210       +7     
  Branches     4424     4427       +3     
==========================================
+ Hits        16667    16669       +2     
- Misses      11622    11627       +5     
  Partials      914      914
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 94.69% <100%> (+0.01%) ⬆️
.../datascience/interactive-common/interactiveBase.ts 18.15% <9.09%> (-0.18%) ⬇️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ea8e8...72ef028. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 16, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 30d50bb into microsoft:master Dec 16, 2019
DonJayamanne added a commit that referenced this pull request Dec 16, 2019
@DonJayamanne
Add progress indicator when switching kernels (#9134)
2b6fd69 
* Add progress indicator when switching kernels
* Oops
* Typo
@DonJayamanne DonJayamanne deleted the addKernelSwitcherProgress branch December 17, 2019 17:28
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo