Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of static methods of Logger class #9827

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jan 30, 2020

For #9806

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@karrtikr karrtikr added the no-changelog No news entry required label Jan 30, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoooooooo

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #9827 into master will increase coverage by 0.23%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9827      +/-   ##
==========================================
+ Coverage   60.64%   60.87%   +0.23%     
==========================================
  Files         552      556       +4     
  Lines       29783    30043     +260     
  Branches     4505     4555      +50     
==========================================
+ Hits        18061    18290     +229     
- Misses      10710    10726      +16     
- Partials     1012     1027      +15
Impacted Files Coverage Δ
src/client/common/logger.ts 72.77% <0%> (-1.12%) ⬇️
...reter/locators/services/cacheableLocatorService.ts 84.88% <100%> (ø) ⬆️
...tors/services/workspaceVirtualEnvWatcherService.ts 77.41% <100%> (ø) ⬆️
...ient/interpreter/locators/services/condaService.ts 85.47% <33.33%> (ø) ⬆️
src/client/providers/jediProxy.ts 23.37% <33.33%> (ø) ⬆️
...ication/diagnostics/checks/powerShellActivation.ts 82.05% <50%> (ø) ⬆️
src/client/common/terminal/factory.ts 82.85% <0%> (-13.58%) ⬇️
src/client/common/terminal/activator/base.ts 77.27% <0%> (-9.1%) ⬇️
src/client/common/terminal/service.ts 84.48% <0%> (-8.25%) ⬇️
src/client/common/asyncDisposableRegistry.ts 18.18% <0%> (-4.05%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb7be2...d347998. Read the comment docs.

@karrtikr karrtikr merged commit 89ef1aa into microsoft:master Jan 30, 2020
@karrtikr karrtikr deleted the logg branch January 30, 2020 18:28
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants