Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variables on mac and linux #9903

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Fix variables on mac and linux #9903

merged 1 commit into from
Feb 4, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 4, 2020

Port this fix to release branch:
279f24d

Fixes variable explorer and data viewer

@rchiodo @DonJayamanne
Fix variables on mac and linux (#9897)
1c7d444 
* Fix regexes to work on other platforms

* Fix data frame viewer

* Fix linter problems

Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>
@rchiodo rchiodo added the no-changelog No news entry required label Feb 4, 2020
@rchiodo rchiodo self-assigned this Feb 4, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #9903 into release-2020.02 will decrease coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.02    #9903      +/-   ##
===================================================
- Coverage            61.22%   61.21%   -0.01%     
===================================================
  Files                  563      564       +1     
  Lines                30058    30061       +3     
  Branches              4545     4545              
===================================================
  Hits                 18403    18403              
- Misses               10626    10629       +3     
  Partials              1029     1029
Impacted Files Coverage Δ
...atascience-ui/data-explorer/globalJQueryImports.ts 0% <0%> (ø)
src/client/datascience/jupyter/jupyterVariables.ts 50.59% <83.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ad067...1c7d444. Read the comment docs.

@rchiodo rchiodo merged commit 15d40c4 into release-2020.02 Feb 4, 2020
@rchiodo rchiodo deleted the rchiodo/linux_variables_release branch February 4, 2020 22:19
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

@rchiodo rchiodo

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rchiodo @codecov-io @IanMatthewHuff @karthiknadig