Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Davidkutu/ds scrapbook render fix #9912

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Feb 5, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #9912 into release-2020.02 will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2020.02   #9912      +/-   ##
==================================================
- Coverage            61.21%   61.2%   -0.02%     
==================================================
  Files                  564     564              
  Lines                30061   30061              
  Branches              4545    4545              
==================================================
- Hits                 18403   18399       -4     
- Misses               10629   10632       +3     
- Partials              1029    1030       +1
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d40c4...e7c5334. Read the comment docs.

@DavidKutu DavidKutu merged commit 9f5ac3f into release-2020.02 Feb 5, 2020
@DavidKutu DavidKutu deleted the davidkutu/DSScrapbookRenderFix branch February 5, 2020 18:04
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants