Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port server name fix to release #9970

Conversation

IanMatthewHuff
Copy link
Member

For #9933

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Feb 6, 2020
@IanMatthewHuff IanMatthewHuff changed the title Port server fix to release Port server name fix to release Feb 6, 2020
@IanMatthewHuff
Copy link
Member Author

NPM CI barf

@IanMatthewHuff IanMatthewHuff reopened this Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #9970 into release-2020.02 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.02    #9970      +/-   ##
===================================================
+ Coverage             61.2%   61.23%   +0.03%     
===================================================
  Files                  564      564              
  Lines                30078    30123      +45     
  Branches              4550     4558       +8     
===================================================
+ Hits                 18408    18447      +39     
- Misses               10640    10646       +6     
  Partials              1030     1030
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 95.12% <100%> (+0.01%) ⬆️
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️
src/client/interpreter/activation/service.ts 88.88% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415cab4...2e1d2ac. Read the comment docs.

@IanMatthewHuff
Copy link
Member Author

Next CI failure due to inability to download vscode during test runs...

@IanMatthewHuff IanMatthewHuff reopened this Feb 7, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IanMatthewHuff IanMatthewHuff merged commit 3976296 into microsoft:release-2020.02 Feb 7, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/portEmptyServerFix branch February 7, 2020 00:58
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants