Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For ports with a root process we should show a placeholder if we can't find the command line #4749

Closed
alexr00 opened this issue Mar 24, 2021 · 1 comment · Fixed by microsoft/vscode#119792
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote-explorer verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Mar 24, 2021

Now that we try to find root ports (#4654), we do know that a process is listening on a port even if we can't access the command line or process ID.

We should show placeholder text in the "Running Process" column, and show the "filled circle" icon for root ports even if we can't read the command line.

@alexr00 alexr00 self-assigned this Mar 24, 2021
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug remote-explorer labels Mar 24, 2021
@alexr00 alexr00 added this to the March 2021 milestone Mar 24, 2021
alexr00 added a commit to microsoft/vscode that referenced this issue Mar 24, 2021
alexr00 added a commit to microsoft/vscode that referenced this issue Mar 24, 2021
@alexr00
Copy link
Member Author

alexr00 commented Mar 24, 2021

To verify:

  1. Connect to a linux remote and make sure that "remote.autoForwardPortsSource": "process".
  2. Start a process as root and doesn't have the port number in the command line (ex. sudo npx http-server).
  3. Open the Ports view and forward the port from step 2.
  4. Verify that the new forwarded port has a filled in circle as its icon. Verify that the "Running Process" column reads "Command line unavailable).
  5. Kill the process from step 2.
  6. Verify that your forwarded port has an empty circle as its icon. Verify that the "Running Process" column is empty.
  7. Repeat steps 2-4.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug remote-explorer verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants