Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Add development configuration files' support to navigate to the documentation for a feature/configuration #5899

Closed
chrmarti opened this issue Nov 16, 2021 · 5 comments
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item
Milestone

Comments

@chrmarti
Copy link
Contributor

No description provided.

@chrmarti chrmarti added containers Issue in vscode-remote containers plan-item A plan item labels Nov 16, 2021
@chrmarti chrmarti added this to the November 2021 milestone Nov 16, 2021
@chrmarti chrmarti self-assigned this Nov 16, 2021
@chrmarti
Copy link
Contributor Author

Adding an optional documentationURL string property to the feature type. /cc @joshspicer

@Chuxel Was the idea to also have this for definitions? Where would I read the URL from?

@chrmarti
Copy link
Contributor Author

Not adding to the test plan since we are not using this yet.

@Chuxel
Copy link
Member

Chuxel commented Nov 29, 2021

@chrmarti I didn't realize you were waiting on me for anything here. Holiday brain. I thought I'd responded to the deffiniution bit but must not have comitted it. I can look at adding documentation URLs in features.json since those are well known.

For the definitions, I'm not sure where we'd do config-as-code here. We could use definition-manifest.json if we needed a spot. Otherwise, we'd for now we'd just have to assume where it originated.

Chuxel added a commit to microsoft/vscode-dev-containers that referenced this issue Nov 30, 2021
@Chuxel
Copy link
Member

Chuxel commented Nov 30, 2021

@chrmarti Just pushed an update so we can cut a remote-containers repo release at any point.

@chrmarti
Copy link
Contributor Author

chrmarti commented Jan 7, 2022

@Chuxel Linking to the README's in vscode-dev-containers for now. Let me know if/when you add a doc URI to the metadata.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

2 participants