Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to use go to definition when physical path requires a resolver #19

Closed
unbyte opened this issue Jun 16, 2021 · 7 comments
Closed

fail to use go to definition when physical path requires a resolver #19

unbyte opened this issue Jun 16, 2021 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@unbyte
Copy link

unbyte commented Jun 16, 2021

e.g.

import foo from './foo'

In local repositories, vscode can know the physical path is ./foo.js or ./foo.ts.
But with this plugin it will throw Unable to open 'foo': Unable to read file 'vscode-vfs://github/**/foo' (Error: Unable to resolve non-existing file 'vscode-vfs://github/**/foo').

@eamodio
Copy link
Contributor

eamodio commented Jun 21, 2021

@mjbvz Is there something we can do here with the single-file language service for TypeScript?

@jianboy
Copy link

jianboy commented Jun 23, 2021

=======================================
@eamodio @mjbvz
Give you a tip. you can refer to the gihtub1s to develop.

动画 (1)

=======================================

@unbyte
Copy link
Author

unbyte commented Jun 23, 2021

=======================================
Give you a tip. you can refer to the gihtub1s to implement it.

动画 (1)

=======================================

😁 I've been using it since it was published and it works well. I just want to see this plugin provided by Github and Vscode official teams works well too.

@mjbvz
Copy link

mjbvz commented Jun 29, 2021

@eamodio What should the path to foo look like in this case? Is it just missing the file extension?

/cc @amcasey

@eamodio
Copy link
Contributor

eamodio commented Jun 29, 2021

@mjbvz I would think <current-file-path>/foo.js|ts>

@amcasey
Copy link
Member

amcasey commented Jun 29, 2021

There are actually quite a few file extensions to check, but I don't think you have to worry about path mappings or anything like that when it's unambiguously a relative path.

@joyceerhl joyceerhl self-assigned this Oct 21, 2021
@joyceerhl
Copy link
Contributor

Duplicate of microsoft/vscode#146853

@joyceerhl joyceerhl marked this as a duplicate of microsoft/vscode#146853 Dec 6, 2022
@joyceerhl joyceerhl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@joyceerhl joyceerhl added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

6 participants