Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sublime folder finder to support SublimeText from 4.x #149

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

boxsnake
Copy link

What changed

Former:

The plugin detect Sublime Text 3/Packages/Preferences.sublime-settings for Sublime Text settings.

Updated:

I changed this plugins for detecting both Sublime Text 3/Packages/Preferences.sublime-settings and Sublime Text/Packages/Preferences.sublime-settings for any existing SublimeText setting file.

Why

As for Sublime Text 4, it is named to Sublime Text. As a result, the settings file is located in Sublime Text folder rather than Sublime Text 3.

@ghost
Copy link

ghost commented Feb 27, 2022

CLA assistant check
All CLA requirements met.

@benjaminloerincz
Copy link

LGTM

Copy link

@benjaminloerincz benjaminloerincz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@lkalabis lkalabis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Jakob-Rufcbs Jakob-Rufcbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@chrisands
Copy link

@joaomoreno can we merge it?

@benjaminloerincz
Copy link

@lszomoru @TylerLeonhardt can we merge it?

Copy link

@Jakob-Ruf Jakob-Ruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants