Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support ?vscode-coi argument for Cross Origin Isolation #31

Closed
jgentes opened this issue Jul 18, 2022 · 2 comments · Fixed by #35
Closed

Update to support ?vscode-coi argument for Cross Origin Isolation #31

jgentes opened this issue Jul 18, 2022 · 2 comments · Fixed by #35
Assignees
@jrieken @aeschli
Milestone
July 2022

Comments

@jgentes
Copy link

jgentes commented Jul 18, 2022

Would love to use this to test SharedArrayBuffer support, which requires Cross Origin Isolation that can only be enabled through the new ?vscode-coi argument detailed here: microsoft/vscode#137884
@jgentes jgentes mentioned this issue Jul 18, 2022
Closed
@jrieken
Copy link
Member

jrieken commented Jul 20, 2022

Mostly done with #34 but @aeschli has ideas to make this more user friendly

@jgentes
Copy link
Author

jgentes commented Jul 20, 2022

Thanks for the quick turnaround!

aeschli added a commit that referenced this issue Jul 21, 2022
@aeschli
Allow to set coi on the command line. Fixes #31
340e33f
@aeschli aeschli mentioned this issue Jul 21, 2022
Merged
@aeschli aeschli added this to the July 2022 milestone Jul 21, 2022
@christian-bromann christian-bromann mentioned this issue Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Allow to set coi on the command line microsoft/vscode-test-web
3 participants
@jgentes @jrieken @aeschli