Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api extractor #246

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Api extractor #246

merged 2 commits into from
Dec 17, 2024

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Dec 13, 2024

Porting #245 to main repo so we can kick off a test build

This bundles all of the d.ts files into a single d.ts using api-extractor. This reduces the package size and also fixes the typings when using node16/nodenext. These module resolution strategies can't resolve the extension-less imports that are used the current version of the typings

This bundles all of the d.ts files into a single entrypoint using `api-extractor`. This reduces the package size and also fixes the typings when using `node16`/`nodenext`. These can't resolve the extension-less imports in current version of the  typings
@mjbvz mjbvz self-assigned this Dec 13, 2024
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 13, 2024
@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 13, 2024

Confirmed that our pipeline builds create the correct types file:

Screenshot 2024-12-13 at 9 28 52 AM

@alexdima alexdima merged commit 62fcd6f into main Dec 17, 2024
8 checks passed
@alexdima alexdima deleted the api-extractor branch December 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants