Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relative paths in depedencies #673

Closed
qarlosalberto opened this issue Dec 29, 2021 · 3 comments
Closed

Support relative paths in depedencies #673

qarlosalberto opened this issue Dec 29, 2021 · 3 comments
Assignees
@joaomoreno
Labels
*out-of-scope Posted issue is not in scope of VS Code

Comments

@qarlosalberto
Copy link

  • npm: 8.1.0
  • vsce: 2.5.3

I have a npm package (colibri) in a local folder and a VSCode extension (vscode-teroshdl) in other folder. colibri is a dependency of vscode-teroshdl:

    "dependencies": {
        "colibri": "file:../colibri"
    },

When I try to package the VSCode extension:

          cd colibri
          npm install
          cd ../vscode-terosHDL
          npm install
          vsce package

It fails with the error:

 ERROR  invalid relative path: extension/../colibri/node_modules/cli-progress/CHANGES.md
@joaomoreno joaomoreno changed the title Error relative path Support relative paths in depedencies Dec 31, 2021
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Dec 31, 2021
@joaomoreno joaomoreno self-assigned this Dec 31, 2021
@mohanraj-r mohanraj-r mentioned this issue Apr 26, 2022
Closed
68 tasks
@mohanraj-r mohanraj-r mentioned this issue May 10, 2022
Merged
5 tasks
smithgp added a commit to forcedotcom/analyticsdx-vscode that referenced this issue Jun 29, 2022
@smithgp
Use npm 6 for build & packaging
5538997 
This is to work around several issues use npm 7 or 8 with vscode
packaging:
* microsoft/vscode-vsce#439
* microsoft/vscode-vsce#673
smithgp added a commit to forcedotcom/analyticsdx-vscode that referenced this issue Jun 29, 2022
@smithgp
Use npm 6 for build & packaging
ee503c7 
This is to work around several issues use npm 7 or 8 with vscode
packaging:
* microsoft/vscode-vsce#439
* microsoft/vscode-vsce#673
@smithgp smithgp mentioned this issue Jun 29, 2022
Merged
smithgp added a commit to forcedotcom/analyticsdx-vscode that referenced this issue Jun 30, 2022
@smithgp
Update versions (#138)
e408dcf 
* Update to node 16.13.10

* Update to vscode 1.67 api

* Update to typescript 4.6.3

* Update to prettier 2.6.2

* Update shx to 3.3.4

* Update request-light to 0.5.8

* Update glob to 8.0.3

* Update semver to 7.3.7

* Update sinon to 14.0.0

* Update chai to 4.3.6

* Update mocha to 10.0.0

* Update @vscode/test-electron to 2.1.3

* Update better-ajv-erros to 1.2.0

* Update vsce to 1.103.1

* Use npm 6 for build & packaging

This is to work around several issues use npm 7 or 8 with vscode
packaging:
* microsoft/vscode-vsce#439
* microsoft/vscode-vsce#673

* Fix for vscode tests on windows & mac
@VitGottwald
Copy link

Have you tried running npx @vscode/vsce ls to diagnose the issue?

It helped me to resolve a very similar issue. In my case it was caused by the presence of node_modules folder above the current folder. vsce tried to package it in and was failing with a message similar to yours. Adding ../**/* to .vscodeignore resolved the issue for me.

@ben5311
Copy link

ben5311 commented Jun 18, 2023

Have you tried running npx @vscode/vsce ls to diagnose the issue?

It helped me to resolve a very similar issue. In my case it was caused by the presence of node_modules folder above the current folder. vsce tried to package it in and was failing with a message similar to yours. Adding ../**/* to .vscodeignore resolved the issue for me.

Thank you, had the same issue!

@joaomoreno joaomoreno added *out-of-scope Posted issue is not in scope of VS Code and removed feature-request Request for new features or functionality labels Dec 16, 2023
@joaomoreno joaomoreno closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2023
@OrkunTokdemir
Copy link

@VitGottwald Thank you. Your answer helped me a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joaomoreno @qarlosalberto @VitGottwald @ben5311 @OrkunTokdemir