Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest matching commands if the user makes a typo #358

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Suggest matching commands if the user makes a typo #358

merged 6 commits into from
Jun 12, 2019

Conversation

jamesgeorge007
Copy link
Contributor

Fixes #356

Suggests matching commands if the user makes a typo:-

Screenshot from 2019-06-03 22-32-20

@jamesgeorge007
Copy link
Contributor Author

@joaomoreno Thoughts 🤔

joaomoreno
joaomoreno requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea!

src/main.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@joaomoreno joaomoreno added this to the June 2019 milestone Jun 4, 2019
@joaomoreno joaomoreno self-assigned this Jun 4, 2019
@jamesgeorge007 @joaomoreno
Minor refactor
ca1847c 
prettify

Co-Authored-By: João Moreno <mail@joaomoreno.com>
@jamesgeorge007 jamesgeorge007 force-pushed the feat/suggest-commands branch from d7fee90 to ca1847c Compare June 4, 2019 17:10
@jamesgeorge007
Copy link
Contributor Author

@joaomoreno Hope, we're good to go 👍

@joaomoreno joaomoreno merged commit 3791361 into microsoft:master Jun 12, 2019
@joaomoreno
Copy link
Member

Awesome thanks! 🍻

yarn.lock changes were missing again and I've refactored everything just a bit.

@jamesgeorge007 jamesgeorge007 deleted the feat/suggest-commands branch June 12, 2019 10:24
@joaomoreno
Copy link
Member

Released 1.63.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.

Show up suitable messages if the user makes a typo.
2 participants
@jamesgeorge007 @joaomoreno