Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): Minor refactor #366

Merged
merged 1 commit into from
Jun 20, 2019
Merged

fix(chore): Minor refactor #366

merged 1 commit into from
Jun 20, 2019

Conversation

jamesgeorge007
Copy link
Contributor

Use process.platform instead of os.platform() to maintain consistency.

@jamesgeorge007
Minor refactor
5420934 
use process.platform instead of os.platform()
@jamesgeorge007
Copy link
Contributor Author

@joaomoreno Makes sense 🤔

@raix
Copy link
Contributor

raix commented Jun 19, 2019 •
edited
Loading

process.platform was added in v0.1.16 and os.platform() was added in v0.5.0 (later)
Is os.platform() being deprecated?
EDIT: I would expect process.platform to go at some point, I read it as part of a refactoring / restructuring in the node js api - but I could be wrong

@jamesgeorge007
Copy link
Contributor Author

@raix There is no harm in having os.platform(). But still, the refactor ensures consistency IMO.

@joaomoreno
Copy link
Member

joaomoreno commented Jun 20, 2019 •
edited
Loading

Sure, why not. Thanks! 🍻

@joaomoreno joaomoreno closed this Jun 20, 2019
@joaomoreno joaomoreno merged commit 5581573 into microsoft:master Jun 20, 2019
@joaomoreno joaomoreno self-assigned this Jun 20, 2019
@joaomoreno joaomoreno added this to the June 2019 milestone Jun 20, 2019
@jamesgeorge007 jamesgeorge007 deleted the hotfix/refactor branch July 1, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @raix @joaomoreno