Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libsecret to Dockerfile and mention the dependency on README #646

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Add libsecret to Dockerfile and mention the dependency on README #646

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00de144
Dockerfile: libsecret is a dependency for keytar
microhobby Nov 4, 2021
a4ec128
README: Mention that vsce uses keytar and need the libsecret on Linux
microhobby Nov 4, 2021
5c1ff00
Update README.md
joaomoreno Nov 4, 2021
d9d3b4a
Update README.md
joaomoreno Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
FROM node:12-alpine
RUN apk add --update-cache \
libsecret \
&& rm -rf /var/cache/apk/*
WORKDIR /opt/vsce
COPY package.json package-lock.json ./
RUN npm install
Expand All @@ -7,4 +10,4 @@ RUN npm run compile
RUN rm package-lock.json tsconfig.json
VOLUME /workspace
WORKDIR /workspace
ENTRYPOINT ["/opt/vsce/vsce"]
ENTRYPOINT ["/opt/vsce/vsce"]
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@

Or simply [Docker](#via-docker).

### On Linux
joaomoreno marked this conversation as resolved.
Show resolved Hide resolved

This project uses [keytar](https://www.npmjs.com/package/keytar) that uses `libsecret`, so you may need to install it before running `vsce`.
joaomoreno marked this conversation as resolved.
Show resolved Hide resolved

Depending on your distribution, you will need to run the following command:

- Debian/Ubuntu: `sudo apt-get install libsecret-1-dev`
- Alpine: `apk add libsecret`
- Red Hat-based: `sudo yum install libsecret-devel`
- Arch Linux: `sudo pacman -S libsecret`

## Usage

Install vsce globally:
Expand Down