Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in Dev perf performance error page #313

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix typos in Dev perf performance error page #313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b71ba9f
Improves text by adding ":" to end of sentence to keep consistency
ViniciusALS Jan 23, 2025
f3d6ca5
Fixes typo. Removes misplaced "the" from sentence
ViniciusALS Jan 23, 2025
99496f9
Fixes typo. Adds missing "to" to sentence
ViniciusALS Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions [dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Automatic renderer profiling

The renderer process is monitored for "hangs" and when those occur automatic profiling is started. It works as follows
The renderer process is monitored for "hangs" and when those occur automatic profiling is started. It works as follows:

* after startup a performance baseline is computed (on fast machines this is fine-tuned to be roughly one frame at 64fps, 15ms)
* when a [long task](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceLongTaskTiming) that is 10x of the baseline is reported, automatic renderer profiling is started (for 5secs)
Expand All @@ -9,9 +9,9 @@ The renderer process is monitored for "hangs" and when those occur automatic pro

#### Dealing with `PerfSampleError` error

As mentioned above, hangs are reported as normal- and error-telemetry. When the a certain error event is reported many times it shows up on our error triage page. The error shows a synthetic stacktrace which is the callstack that the profiler saw most often. The top is the slow function and the calls is how it was called.
As mentioned above, hangs are reported as normal- and error-telemetry. When a certain error event is reported many times it shows up on our error triage page. The error shows a synthetic stacktrace which is the callstack that the profiler saw most often. The top is the slow function and the calls is how it was called.

If the error telemetry isn't sufficient you can dig into telemetry. Use the query below but make sure use the right version of VSCode and filter for the name of your function. _Note_ that only stable versions of VS Code yield usable results. That is because insiders generates too little data. The query will show how many machines were affected and what the average hang-time was.
If the error telemetry isn't sufficient you can dig into telemetry. Use the query below but make sure to use the right version of VSCode and filter for the name of your function. _Note_ that only stable versions of VS Code yield usable results. That is because insiders generates too little data. The query will show how many machines were affected and what the average hang-time was.

```js
RawEventsVSCode
Expand Down