ReviewZoneWidget makes duplicate calls to show() + hide()

Fixes #174263
microsoft · Mar 9, 2023 · 10209b9 · 10209b9
1 parent 2e34c9a
commit 10209b9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts b/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts
@@ -285,10 +285,6 @@ export class ReviewZoneWidget extends ZoneWidget implements ICommentThreadWidget
 	toggleExpand() {
 		if (this._isExpanded) {
 			this._commentThread.collapsibleState = languages.CommentThreadCollapsibleState.Collapsed;
-			this.hide();
-			if (!this._commentThread.comments || !this._commentThread.comments.length) {
-				this.deleteCommentThread();
-			}
 		} else {
 			this._commentThread.collapsibleState = languages.CommentThreadCollapsibleState.Expanded;
 		}
@@ -468,6 +464,10 @@ export class ReviewZoneWidget extends ZoneWidget implements ICommentThreadWidget
 			if (this.editor.hasWidgetFocus()) {
 				this.editor.focus();
 			}
+
+			if (!this._commentThread.comments || !this._commentThread.comments.length) {
+				this.deleteCommentThread();
+			}
 		}
 		super.hide();
 	}