Fix issue with disposable after being disposed (#229980)

dont add disposable after disposed
microsoft · Sep 27, 2024 · 2b5ec43 · 2b5ec43
1 parent f029ec3
commit 2b5ec43
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/src/vs/workbench/contrib/chat/browser/chatContentParts/chatAttachmentsContentPart.ts b/src/vs/workbench/contrib/chat/browser/chatContentParts/chatAttachmentsContentPart.ts
@@ -133,17 +133,19 @@ export class ChatAttachmentsContentPart extends Disposable {
 
 			if (file) {
 				widget.style.cursor = 'pointer';
-				this.attachedContextDisposables.add(dom.addDisposableListener(widget, dom.EventType.CLICK, async (e: MouseEvent) => {
-					dom.EventHelper.stop(e, true);
-					this.openerService.open(
-						file,
-						{
-							fromUserGesture: true,
-							editorOptions: {
-								selection: range
-							} as any
-						});
-				}));
+				if (!this.attachedContextDisposables.isDisposed) {
+					this.attachedContextDisposables.add(dom.addDisposableListener(widget, dom.EventType.CLICK, async (e: MouseEvent) => {
+						dom.EventHelper.stop(e, true);
+						this.openerService.open(
+							file,
+							{
+								fromUserGesture: true,
+								editorOptions: {
+									selection: range
+								} as any
+							});
+					}));
+				}
 			}
 
 			widget.ariaLabel = ariaLabel;