Progress API: Can't report 0 progress (fixes #46636)

microsoft · Mar 27, 2018 · 4831efe · 4831efe
1 parent d656cda
commit 4831efe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/vs/workbench/browser/parts/notifications/notificationsViewer.ts b/src/vs/workbench/browser/parts/notifications/notificationsViewer.ts
@@ -468,12 +468,12 @@ export class NotificationTemplateRenderer {
 		}
 
 		// Total / Worked
-		else if (state.total || state.worked) {
-			if (state.total) {
+		else if (typeof state.total === 'number' || typeof state.worked === 'number') {
+			if (typeof state.total === 'number') {
 				this.template.progress.total(state.total);
 			}
 
-			if (state.worked) {
+			if (typeof state.worked === 'number') {
 				this.template.progress.worked(state.worked).getContainer().show();
 			}
 		}

diff --git a/src/vs/workbench/services/progress/browser/progressService2.ts b/src/vs/workbench/services/progress/browser/progressService2.ts
@@ -211,7 +211,7 @@ export class ProgressService2 implements IProgressService2 {
 		};
 
 		const updateProgress = (notification: INotificationHandle, percentage?: number): void => {
-			if (typeof percentage === 'number' && percentage > 0) {
+			if (typeof percentage === 'number' && percentage >= 0) {
 				notification.progress.total(100); // always percentage based
 				notification.progress.worked(percentage);
 			} else {