Skip to content

Commit

Permalink
Don't cache webview view title
Browse files Browse the repository at this point in the history
Revert #105867
  • Loading branch information
mjbvz committed Sep 24, 2020
1 parent 7506b2b commit 591c3b5
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ declare const ResizeObserver: any;

const storageKeys = {
webviewState: 'webviewState',
title: 'title'
} as const;

export class WebviewViewPane extends ViewPane {
Expand Down Expand Up @@ -71,11 +70,6 @@ export class WebviewViewPane extends ViewPane {
this.memento = new Memento(`webviewView.${this.id}`, storageService);
this.viewState = this.memento.getMemento(StorageScope.WORKSPACE);

const storedTitle = this.viewState[storageKeys.title];
if (typeof storedTitle === 'string') {
this.updateTitle(storedTitle);
}

this._register(this.onDidChangeBodyVisibility(() => this.updateTreeVisibility()));
this.updateTreeVisibility();
}
Expand Down Expand Up @@ -124,7 +118,6 @@ export class WebviewViewPane extends ViewPane {
if (this._webview) {
this.viewState[storageKeys.webviewState] = this._webview.state;
}
this.viewState[storageKeys.title] = this.setTitle;

this.memento.saveMemento();
super.saveState();
Expand Down

0 comments on commit 591c3b5

Please sign in to comment.