Fixes #3462

microsoft · Feb 25, 2016 · 6f8016b · 6f8016b
1 parent 78b557a
commit 6f8016b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/vs/editor/common/viewLayout/viewLineParts.ts b/src/vs/editor/common/viewLayout/viewLineParts.ts
@@ -7,6 +7,7 @@
 import * as strings from 'vs/base/common/strings';
 import {Arrays} from 'vs/editor/common/core/arrays';
 import {ILineToken, IRange, IViewLineTokens} from 'vs/editor/common/editorCommon';
+import {Range} from 'vs/editor/common/core/range';
 
 export interface ILineParts {
 
@@ -17,9 +18,17 @@ export interface ILineParts {
 	findIndexOfOffset(offset:number): number;
 }
 
+function cmpLineDecorations(a:ILineDecoration, b:ILineDecoration): number {
+	return Range.compareRangesUsingStarts(a.range, b.range);
+}
+
 export function createLineParts(lineNumber:number, lineContent:string, lineTokens:IViewLineTokens, rawLineDecorations:ILineDecoration[], renderWhitespace:boolean): ILineParts {
 	if (renderWhitespace) {
+		let oldLength = rawLineDecorations.length;
 		rawLineDecorations = insertWhitespace(lineNumber, lineContent, lineTokens.getFauxIndentLength(), rawLineDecorations);
+		if (rawLineDecorations.length !== oldLength) {
+			rawLineDecorations.sort(cmpLineDecorations);
+		}
 	}
 
 	if (rawLineDecorations.length > 0) {

diff --git a/src/vs/editor/common/viewLayout/viewLineRenderer.ts b/src/vs/editor/common/viewLayout/viewLineRenderer.ts
@@ -67,7 +67,7 @@ export function renderLine(input:IRenderLineInput): IRenderLineOutput {
 
 		let partRendersWhitespace = false;
 		if (renderWhitespace) {
-			partRendersWhitespace = (/whitespace$/.test(part.type));
+			partRendersWhitespace = (/\bwhitespace\b/.test(part.type));
 		}
 
 		let toCharIndex = lineTextLength;

diff --git a/src/vs/editor/test/common/viewLayout/viewLineParts.test.ts b/src/vs/editor/test/common/viewLayout/viewLineParts.test.ts
@@ -37,6 +37,19 @@ suite('Editor ViewLayout - ViewLineParts', () => {
 		]);
 	});
 
+	test('issue #3462: no whitespace shown at the end of a decorated line', () => {
+
+		var result = LineDecorationsNormalizer.normalize(3, [
+			newDecoration(3, 15, 3, 21, 'trailing whitespace'),
+			newDecoration(3, 20, 3, 21, 'inline-folded'),
+		]);
+
+		assert.deepEqual(result, [
+			new DecorationSegment(14, 18, 'trailing whitespace'),
+			new DecorationSegment(19, 19, 'trailing whitespace inline-folded')
+		]);
+	});
+
 	test('ViewLineParts', () => {
 
 		assert.deepEqual(LineDecorationsNormalizer.normalize(1, [